linux-kernel - Re: [PATCH] at91_mci: use generic GPIO calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080207181022.5ba37443@poseidon.drzeus.cx>
Date:	Thu, 7 Feb 2008 18:10:22 +0100
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	David Brownell <david-b@...bell.net>,
	linux-arm-kernel@...ts.arm.linux.org.uk,
	Andrew Victor <linux@...im.org.za>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] at91_mci:  use generic GPIO calls

On Mon, 04 Feb 2008 18:12:48 +0100
Nicolas Ferre <nicolas.ferre@...el.com> wrote:

> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> Update the AT91 MMC driver to use the generic GPIO calls instead of the
> AT91-specific calls; and to request (and release) those GPIO signals.
> 
> That required updating the probe() fault cleanup codepaths.  Now there
> is a single sequence for freeing resources, in reverse order of their
> allocation.  Also that code uses use dev_*() for messaging, and has less
> abuse of KERN_ERR.
> 
> Likewise with updating remove() cleanup.  This had to free the GPIOs,
> and while adding that code I noticed and fixed two other problems:  it
> was poking at a workqueue owned by the mmc core; and in one (rare)
> case would try freeing an IRQ that it didn't allocate.
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
> ---

Applied thanks.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/