linux-kernel - Re: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4A9328DB-F68C-4C09-B762-44FEA85DD12E@kernel.crashing.org>
Date:	Tue, 5 Feb 2008 10:06:04 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Zhang Wei <wei.zhang@...escale.com>, mporter@...nel.crashing.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.


On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote:

>>
>> +	aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
>> +	sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
>
> What happens if either of these properties is missing?

Should we add __must_check to of_get_property?

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/