linux-kernel - Re: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080205164425.b6af5bff.sfr@canb.auug.org.au>
Date:	Tue, 5 Feb 2008 16:44:25 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Zhang Wei <wei.zhang@...escale.com>
Cc:	mporter@...nel.crashing.org, galak@...nel.crashing.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.

On Wed, 30 Jan 2008 18:30:52 +0800 Zhang Wei <wei.zhang@...escale.com> wrote:
>
> -void fsl_rio_setup(int law_start, int law_size)
> +int fsl_rio_setup(struct of_device *dev)
>  {

> +	if (!dev->node) {
> +		dev_err(&dev->dev, "Device OF-Node is NULL");
> +		return -EFAULT;

Probably -EINVAL would be better. Here and all the other -EFAULTs.

> +	aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
> +	sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);

What happens if either of these properties is missing?

> +static struct of_device_id fsl_of_rio_rpn_ids[] = {

This should be "const" please.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped