lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080206091744.ZZRA012@mailhub.coreip.homeip.net>
Date:	Wed, 6 Feb 2008 09:19:39 -0500
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] Input updates for 2.6.25-rc0

On Wed, Feb 06, 2008 at 08:56:35AM +0100, Sam Ravnborg wrote:
> >  
> > > 
> > > 
> > > 
> > > i8042_platform_init():
> > > 
> > > +#if defined(__i386__) || defined(__x86_64__)
> > > 
> > > use #ifdef CONFIG_X86?
> > > 
> > 
> > I considered it but above was tested and in line with the style of the
> > rest of the file...
> Then please change the rest of the file so it is consistent
> with the usual style to use our CONFIG_ symbols for
> conditionals like the above.
> 

Will do in the next update. The #if defined(__i386__) code predates
CONFIG_X86_32 and was not updated when this symbol became available.

Overall, do you want me to redo the pull or is it still acceptable?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ