linux-kernel - Re: [PATCH] x86_64: fix page table size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080207115442.GB387@elte.hu>
Date:	Thu, 7 Feb 2008 12:54:42 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Yinghai Lu <Yinghai.Lu@....COM>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: fix page table size


* Andi Kleen <andi@...stfloor.org> wrote:

> Yinghai Lu <Yinghai.Lu@....COM> writes:
> >
> > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > index eb376b5..31f0e82 100644
> > --- a/arch/x86/mm/init_64.c
> > +++ b/arch/x86/mm/init_64.c
> > @@ -370,7 +370,7 @@ static void __init find_early_table_space(unsigned long end)
> >  
> >  	puds = (end + PUD_SIZE - 1) >> PUD_SHIFT;
> >  	tables = round_up(puds * sizeof(pud_t), PAGE_SIZE);
> > -	if (direct_gbpages) {
> > +	if (!direct_gbpages) {
> 
> What tree did you use? The patch I submitted had 
> 
>      if (direct_gbpages == GBP_ON) { 

yes, the bug was introduced in your original submission of gbpages.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/