linux-kernel - Re: [PATCH] x86_64: fix page table size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200802071828.26468.andi@firstfloor.org>
Date:	Thu, 7 Feb 2008 18:28:25 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Yinghai Lu <Yinghai.Lu@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: fix page table size

On Thursday 07 February 2008 12:54:42 Ingo Molnar wrote:
> * Andi Kleen <andi@...stfloor.org> wrote:
> > Yinghai Lu <Yinghai.Lu@....COM> writes:
> > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > > index eb376b5..31f0e82 100644
> > > --- a/arch/x86/mm/init_64.c
> > > +++ b/arch/x86/mm/init_64.c
> > > @@ -370,7 +370,7 @@ static void __init find_early_table_space(unsigned
> > > long end)
> > >
> > >  	puds = (end + PUD_SIZE - 1) >> PUD_SHIFT;
> > >  	tables = round_up(puds * sizeof(pud_t), PAGE_SIZE);
> > > -	if (direct_gbpages) {
> > > +	if (!direct_gbpages) {
> >
> > What tree did you use? The patch I submitted had
> >
> >      if (direct_gbpages == GBP_ON) {
>
> yes, the bug was introduced in your original submission of gbpages

I see yes. The original was ok I think, but it must have been a typo when
I switched the boolean to a enum on Thomas request and for some
reason the new breakage didn't show up on my testing.

I wonder why you didn't keep the enum even though Thomas
insisted on it. Since you removed it again the safest would have been
to just keep it correct as it originally was. And it was rather pointless
to force me to do changes when you then afterwards half way rewrite the code 
anyways. To be honest that habit makes it rather unpleasant to submit
patch to you recently. At least you could have indicated that in advance
and safe everybody trouble.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/