linux-kernel - Re: [PATCH 1/1] mxser: convert large macros to functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080208134115.9289b7c7.akpm@linux-foundation.org>
Date:	Fri, 8 Feb 2008 13:41:15 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, hch@....de
Subject: Re: [PATCH 1/1] mxser: convert large macros to functions

On Fri,  8 Feb 2008 10:16:48 +0100
Jiri Slaby <jirislaby@...il.com> wrote:

> From: Christoph Hellwig <hch@....de>
> 
> From: Christoph Hellwig <hch@....de>
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Acked-by: Jiri Slaby <jirislaby@...il.com>

This should have been Signed-off-by: - you were in the delivery path.

I'll make that change.

> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c

Has this been runtime tested?

> -	DISABLE_MOXA_MUST_ENCHANCE_MODE(io);
> +	mxser_disable_must_enchance_mode(io);

hm, what's all this "enchance" stuff throughout the driver?  Did it mean
"enhance"?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/