linux-kernel - Re: [PATCH 1/1] mxser: convert large macros to functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47ACD0BD.9070609@gmail.com>
Date:	Fri, 08 Feb 2008 22:59:25 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, hch@....de
Subject: Re: [PATCH 1/1] mxser: convert large macros to functions

On 02/08/2008 10:41 PM, Andrew Morton wrote:
> On Fri,  8 Feb 2008 10:16:48 +0100
> Jiri Slaby <jirislaby@...il.com> wrote:
> 
>> From: Christoph Hellwig <hch@....de>
>>
>> From: Christoph Hellwig <hch@....de>
>>
>> Signed-off-by: Christoph Hellwig <hch@....de>
>> Acked-by: Jiri Slaby <jirislaby@...il.com>
> 
> This should have been Signed-off-by: - you were in the delivery path.
> 
> I'll make that change.
> 
>> --- a/drivers/char/mxser.c
>> +++ b/drivers/char/mxser.c
> 
> Has this been runtime tested?

Not by me, only compiled, sparsed, checkpatched and reviewed on my side (hence 
the ack).

>> -	DISABLE_MOXA_MUST_ENCHANCE_MODE(io);
>> +	mxser_disable_must_enchance_mode(io);
> 
> hm, what's all this "enchance" stuff throughout the driver?  Did it mean
> "enhance"?

I have no idea. It seems so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/