linux-kernel - Re: m68knommu compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0802090959g367ef6a4h304b01e6f930781f@mail.gmail.com>
Date:	Sat, 9 Feb 2008 12:59:50 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	schwidefsky@...ibm.com, "Bryan Wu" <Bryan.Wu@...log.com>
Cc:	"Adrian Bunk" <bunk@...nel.org>, gerg@...inux.org,
	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: m68knommu compile error

On Feb 9, 2008 5:58 AM, Martin Schwidefsky <schwidefsky@...ibm.com> wrote:
> On Sat, 2008-02-09 at 11:21 +0100, Martin Schwidefsky wrote:
> > On Sat, 2008-02-09 at 00:25 +0200, Adrian Bunk wrote:
> > > Commit 2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4 breaks m68knommu:
> >
> > Does the patch below fixes the problem? I tried to cross compile for
> > m68knommu but it seems like you need a special m68k compiler to get it
> > compile all the way through. With the patch it did fail with a different
> > error, so I assume it is fixed. The problem is that the pgtable_t is
> > simply missing for m68knommu, I must have overlooked a reject for one of
> > the constant regenerations of the patch to keep up with upstream. Sorry
> > about that.
>
> This is a problem for all nommu architectures. The patch fixed all four
> of them.
>
> ---
> [PATCH] Add pgtable_t to nommu architectures.
>
> From: Martin Schwidefsky <schwidefsky@...ibm.com>
>
> The pte_fn_t in include/linux/mm.h make it necessary for all
> architecture to define a pgtable_t type, even those that do
> not have an mmu.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@...ibm.com>
> ---
>
>  include/asm-blackfin/page.h  |    1 +
>  include/asm-h8300/page.h     |    1 +
>  include/asm-m68knommu/page.h |    1 +
>  include/asm-v850/page.h      |    1 +
>  4 files changed, 4 insertions(+)
>
> diff -urpN linux-2.6/include/asm-blackfin/page.h linux-2.6-patched/include/asm-blackfin/page.h
> --- linux-2.6/include/asm-blackfin/page.h       2008-02-09 11:46:28.000000000 +0100
> +++ linux-2.6-patched/include/asm-blackfin/page.h       2008-02-09 11:46:36.000000000 +0100
> @@ -39,6 +39,7 @@ typedef struct {
>  typedef struct {
>         unsigned long pgprot;
>  } pgprot_t;
> +typedef struct page *pgtable_t;
>
>  #define pte_val(x)     ((x).pte)
>  #define pmd_val(x)     ((&x)->pmd[0])

thanks, this fixed building Blackfin for me.

Signed-off-by: Mike Frysinger <vapier@...too.org>
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/