linux-kernel - Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1202534628.3102.103.camel@localhost.localdomain>
Date:	Fri, 08 Feb 2008 23:23:48 -0600
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Konrad Rzeszutek <konrad@...nok.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Greg KH <greg@...ah.com>,
	michaelc@...wisc.edu, dwm@...yolf.org, darnok@....org,
	pjones@...hat.com, konradr@...hat.com, konradr@...ux.vnet.ibm.com,
	randy.dunlap@...cle.com, hpa@...or.com, lenb@...nel.org,
	mike.anderson@...ibm.com, dwm@...tin.ibm.com, arjan@...radead.org,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> +       ibft_device = kmalloc(len, GFP_KERNEL);
> +       if (!ibft_device)
> +               return -ENOMEM;
> +
> +       memcpy(ibft_device, hdr, len);

This piece looks a bit odd.  you're making ibft_device an exact
duplicate of ibft_addr (which is reserved in bootmem and lives as long
as the kernel does).  I can't seem to find anywhere you actually modify
ibft_device, so why not just use the original ibft_addr here instead of
making a copy?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/