lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 08 Feb 2008 23:32:12 -0600 From: James Bottomley <James.Bottomley@...senPartnership.com> To: Konrad Rzeszutek <konrad@...nok.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Greg KH <greg@...ah.com>, michaelc@...wisc.edu, dwm@...yolf.org, darnok@....org, pjones@...hat.com, konradr@...hat.com, konradr@...ux.vnet.ibm.com, randy.dunlap@...cle.com, hpa@...or.com, lenb@...nel.org, mike.anderson@...ibm.com, dwm@...tin.ibm.com, arjan@...radead.org, Andy Whitcroft <apw@...dowen.org> Subject: Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7) On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > + if (hdr->id == id_nic) { > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, > + (nic->pci_bdf & 0xff)); > + if (pci_dev) { > + rc = sysfs_create_link(&ibft_kobj->kobj, > + &pci_dev->dev.kobj, "device"); > + pci_dev_put(pci_dev); > + } pci_get_bus_and_slot fails in the presence of PCI domains, which are getting to be fairly common even in medium sized servers ... what happens in that case? James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists