[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080210192721.GA9979@joi>
Date: Sun, 10 Feb 2008 20:27:33 +0100
From: Marcin Slusarz <marcin.slusarz@...il.com>
To: LKML <linux-kernel@...r.kernel.org>
Cc: Jan Kara <jack@...e.cz>
Subject: [PATCH] udf: fix udf_add_free_space
in commit 742ba02a51c8d0bf5446b154531179760c1ed0a2
(udf: create common function for changing free space counter)
by accident I reversed safety condition which lead to
null pointer dereference in case of media error
and wrong counting of free space in normal situation
Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
Cc: Jan Kara <jack@...e.cz>
---
fs/udf/balloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
index a95fcfe..1b809bd 100644
--- a/fs/udf/balloc.c
+++ b/fs/udf/balloc.c
@@ -145,7 +145,7 @@ static bool udf_add_free_space(struct udf_sb_info *sbi,
{
struct logicalVolIntegrityDesc *lvid;
- if (sbi->s_lvid_bh)
+ if (sbi->s_lvid_bh == NULL)
return false;
lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
--
1.5.3.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists