linux-kernel - Re: [PATCH] udf: fix udf_add_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080210200052.GA12569@cvg>
Date:	Sun, 10 Feb 2008 23:00:52 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] udf: fix udf_add_free_space

[Marcin Slusarz - Sun, Feb 10, 2008 at 08:27:33PM +0100]
| in commit 742ba02a51c8d0bf5446b154531179760c1ed0a2
| (udf: create common function for changing free space counter)
| by accident I reversed safety condition which lead to
| null pointer dereference in case of media error
| and wrong counting of free space in normal situation
| 
| Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
| Cc: Jan Kara <jack@...e.cz>
| ---
|  fs/udf/balloc.c |    2 +-
|  1 files changed, 1 insertions(+), 1 deletions(-)
| 
| diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
| index a95fcfe..1b809bd 100644
| --- a/fs/udf/balloc.c
| +++ b/fs/udf/balloc.c
| @@ -145,7 +145,7 @@ static bool udf_add_free_space(struct udf_sb_info *sbi,
|  {
|  	struct logicalVolIntegrityDesc *lvid;
|  
| -	if (sbi->s_lvid_bh)
| +	if (sbi->s_lvid_bh == NULL)
|  		return false;
|  
|  	lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
| -- 

Marcin, actually you've confused me - i always thought the second case
is the explicit form of the first ;)

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/