linux-kernel - Re: [3/6] kgdb: core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080210082408.GA10479@infradead.org>
Date:	Sun, 10 Feb 2008 03:24:08 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@....com.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [3/6] kgdb: core

On Sun, Feb 10, 2008 at 09:02:25AM +0100, Ingo Molnar wrote:
> thanks - i found Sam's mail meanwhile and addressed most of the 
> observations and updated the kgdb.git tree. I'll now check the threads 
> above whether i missed anything. (feel free to point it out if you 
> notice anything outright) As the changes have been janitorial only i 
> refrain from reposting the series once again. The latest shortlog is 
> below.

It would be nice if you could move the kerneldoc comments to the proper
place at least.  And while you're at it please remove all the filenames
in the top-of-file comments, not just in include/asm-generic/kgdb.h.

While we're at it is there a good reason to have that file at all, it's
just function prototypes, and I'd say for now they should just go
into linux/kgdb.h.  If there's a a good reason why architectures
should implement them as inlines we can move them back, but looking
at the x86 implementation I doubt that's the case.

Also it seems at least some of Jan's patches are missing aswell.

I think we really shouldn't rush this too much.  Let's wait until
Monday at least when Jason and Jan are back.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/