linux-kernel - Re: [PATCH] forcedeth: seperate handler for msix and normal int.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B06B9B.1000801@garzik.org>
Date:	Mon, 11 Feb 2008 10:36:59 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Yinghai Lu <Yinghai.Lu@....COM>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Manfred Spraul <manfred@...orfullife.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Ayaz Abdulla <aabdulla@...dia.com>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH] forcedeth: seperate handler for msix and normal int.

Yinghai Lu wrote:
> [PATCH] forcedeth: seperate handler for msix and normal int.
> 
> so we don't need to keep checking np->msi_flags to see if NV_MSI_X_ENABLED is set in
> handler
> 
> Signed-off-by: Yinghai Lu <yinghai.lu@....com>

Two comments:

* can you regenerate this on top of 2.6.25-rc1?

* take a look at the 'fe' branch of 
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git

and see what you think about the work in there.  We need to get cleanups 
like that (and more) upstream.  It also intersects with Tom @ Google's 
"Reduce locking in TX path" patch.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/