linux-kernel - [PATCH 2/8] IPMI: Change device node ordering to reflect probe order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <20080213162212.GB9830@minyard.local>
Date:	Wed, 13 Feb 2008 10:22:12 -0600
From:	Corey Minyard <minyard@....org>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
Cc:	Andrew Morton <akpm@...l.org>, Carol Hebert <cah@...ibm.com>,
	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>
Subject: [PATCH 2/8] IPMI: Change device node ordering to reflect probe order

From: Carol Hebert <cah@...ibm.com>

Currently, on systems with multiple BMC interfaces, the ipmi device
names are being created in reverse order relative to how they are
discovered on the system (e.g. on an IBM x3950 multinode server with N
nodes, the device name for the BMC in the first node is /dev/ipmiN-1 and
the device name for the BMC in the last node is /dev/ipmi0, etc.). The
problem is caused by the list handling routines chosen in dmi_scan.c.
Using list_add() causes the multiple ipmi devices to be added to the
device list using a stack-paradigm and so the ipmi driver subsequently
pulls them off during initialization in LIFO order.  This patch changes
the dmi_save_ipmi_device() list handling paradigm to a queue, thereby
allowing the ipmi driver to build the ipmi device names in the order in
which they are found on the system.

Signed-off-by: Carol Hebert <cah@...ibm.com>
Signed-off-by: Corey Minyard <cminyard@...sta.com>
---

--- linux-2.6.24.orig/drivers/firmware/dmi_scan.c	2008-01-30 11:21:55.000000000 -0800
+++ linux-2.6.24/drivers/firmware/dmi_scan.c	2008-01-30 11:18:05.000000000 -0800
@@ -219,7 +219,7 @@ static void __init dmi_save_ipmi_device(
 	dev->name = "IPMI controller";
 	dev->device_data = data;

-	list_add(&dev->list, &dmi_devices);
+	list_add_tail(&dev->list, &dmi_devices);
 }

 /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/