linux-kernel - Re: [PATCH 7/8] IPMI: convert locked counters to atomics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Feb 2008 18:19:02 -0600
From:	Corey Minyard <minyard@....org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH 7/8] IPMI: convert locked counters to atomics

Andrew Morton wrote:
> The code forgot to initialise all of these.
>
> It just so happens that the all-bits-zero pattern works correctly for all
> current architectures, so the code should work OK.  But there is no reason
> (I hope) why an architecture cannot implement atomic_t as
>
> struct atomic_t {
> 	int counter;
> 	spinlock_t lock;
> };
>
> in which case the results of ATOMIC_INIT() may _not_ be all-zeroes, in
> which case the code will deadlock.
>
> So.  It works, but it's grubby.   Do you still wish to proceed?
>   
Thanks.  Don't proceed for now, I'll work up new patches.

-corey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/