linux-kernel - Re: [PATCH 3/8] IPMI: Run to completion fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <47B38931.8030503@acm.org>
Date:	Wed, 13 Feb 2008 18:20:01 -0600
From:	Corey Minyard <minyard@....org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH 3/8] IPMI: Run to completion fixes

Andrew Morton wrote:
> On Wed, 13 Feb 2008 10:23:42 -0600
> Corey Minyard <minyard@....org> wrote:
>
>   
>> From: Corey Minyard <cminyard@...sta.com>
>>
>> The "run_to_completion" mode was somewhat broken.  Locks need to be
>> avoided in run_to_completion mode, and it shouldn't be used by normal
>> users, just internally for panic situations.
>>
>> This patch removes locks in run_to_completion mode and removes the
>> user call for setting the mode.  The only user was the poweroff
>> code, but it was easily converted to use the polling interface.
>>
>> +	/*
>> +	 * Spin until our message is done.
>> +	 */
>> +	while (atomic_read(&dummy_count) > 0) {
>> +		ipmi_poll_interface(user);
>> +		barrier();
>> +	}
>>     
>
> we'd normally use cpu_relax() here.
>   
Yes, that's what I should have used.  I'll submit a new patch to fix this.

-corey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/