linux-kernel - [2.6 patch] remove aoedev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080214212357.GE23227@cs181133002.pp.htv.fi>
Date:	Thu, 14 Feb 2008 23:23:57 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	"Ed L. Cashin" <ecashin@...aid.com>
Cc:	Jan Engelhardt <jengelh@...putergmbh.de>,
	linux-kernel@...r.kernel.org
Subject: [2.6 patch] remove aoedev_isbusy()

On Wed, Feb 13, 2008 at 05:56:53PM -0500, Ed L. Cashin wrote:
> On Thu, Feb 14, 2008 at 12:05:37AM +0200, Adrian Bunk wrote:
> > On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
> > > 
> > > On Feb 13 2008 23:30, Adrian Bunk wrote:
> > > >
> > > >This patch #if 0's the no longer used aoedev_isbusy().
> > > 
> > > Why not just remove it? (It can be resurrected from earlier
> > > revisions should it be needed again.)
> > 
> > I've switched to doing #if 0 instead since this addresses the
> > "It might be needed in the future." answer I otherwise sometimes
> > got.
> > 
> > But if a maintainer wants to have such a function deleted instead that's 
> > fine with me.
> 
> Hello.  That function can go away.  I have some changes pending, but
> none of them use aoedev_isbusy.  Thanks for Cc-ing me.

Updated patch below

cu
Adrian


<--  snip  -->


This patch removes the no longer used aoedev_isbusy().

Signed-off-by: Adrian Bunk <bunk@...nel.org>

---

 drivers/block/aoe/aoe.h    |    1 -
 drivers/block/aoe/aoedev.c |   18 ------------------
 2 files changed, 19 deletions(-)

13d7ce5f6fa02341f1642f684847ce409bbd5b1d diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 280e71e..5b4c6e6 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -195,7 +195,6 @@ void aoedev_exit(void);
 struct aoedev *aoedev_by_aoeaddr(int maj, int min);
 struct aoedev *aoedev_by_sysminor_m(ulong sysminor);
 void aoedev_downdev(struct aoedev *d);
-int aoedev_isbusy(struct aoedev *d);
 int aoedev_flush(const char __user *str, size_t size);
 
 int aoenet_init(void);
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index f9a1cd9..a1d813a 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -18,24 +18,6 @@ static void skbpoolfree(struct aoedev *d);
 static struct aoedev *devlist;
 static DEFINE_SPINLOCK(devlist_lock);
 
-int
-aoedev_isbusy(struct aoedev *d)
-{
-	struct aoetgt **t, **te;
-	struct frame *f, *e;
-
-	t = d->targets;
-	te = t + NTARGETS;
-	for (; t < te && *t; t++) {
-		f = (*t)->frames;
-		e = f + (*t)->nframes;
-		for (; f < e; f++)
-			if (f->tag != FREETAG)
-				return 1;
-	}
-	return 0;
-}
-
 struct aoedev *
 aoedev_by_aoeaddr(int maj, int min)
 {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/