linux-kernel - Re: [patch] move wakeup code to .c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802150135.07127.lenb@kernel.org>
Date:	Fri, 15 Feb 2008 01:35:06 -0500
From:	Len Brown <lenb@...nel.org>
To:	Pavel Machek <pavel@....cz>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Linux-pm mailing list <linux-pm@...ts.osdl.org>,
	hpa@...or.com, rjw@...k.pl, sam@...nborg.org
Subject: Re: [patch] move wakeup code to .c

scripts/checkpatch.pl
ERROR: do not initialise externals to 0 or NULL
#113: FILE: arch/x86/boot/video-mode.c:29:
+int do_restore = 0;    /* Screen contents changed during mode flip */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#644: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:4:
+extern volatile struct wakeup_header wakeup_header;

WARNING: externs should be avoided in .c files
#644: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:4:
+extern volatile struct wakeup_header wakeup_header;

ERROR: need a space before the open parenthesis '('
#710: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:70:
+               while(1);

WARNING: externs should be avoided in .c files
#968: FILE: arch/x86/kernel/acpi/sleep.c:21:
+extern char wakeup_code_start, wakeup_code_end;

WARNING: externs should be avoided in .c files
#970: FILE: arch/x86/kernel/acpi/sleep.c:23:
+extern unsigned long setup_trampoline(void);

WARNING: externs should be avoided in .c files
#971: FILE: arch/x86/kernel/acpi/sleep.c:24:
+extern void wakeup_long64(void);

WARNING: externs should be avoided in .c files
#973: FILE: arch/x86/kernel/acpi/sleep.c:26:
+extern unsigned long saved_video_mode;

WARNING: externs should be avoided in .c files
#974: FILE: arch/x86/kernel/acpi/sleep.c:27:
+extern long saved_magic;

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#975: FILE: arch/x86/kernel/acpi/sleep.c:28:
+extern volatile unsigned long init_rsp;

WARNING: externs should be avoided in .c files
#975: FILE: arch/x86/kernel/acpi/sleep.c:28:
+extern volatile unsigned long init_rsp;

WARNING: externs should be avoided in .c files
#976: FILE: arch/x86/kernel/acpi/sleep.c:29:
+extern void (*initial_code)(void);

WARNING: externs should be avoided in .c files
#978: FILE: arch/x86/kernel/acpi/sleep.c:31:
+extern int wakeup_pmode_return;

WARNING: externs should be avoided in .c files
#979: FILE: arch/x86/kernel/acpi/sleep.c:32:
+extern char swsusp_pg_dir[PAGE_SIZE];

WARNING: externs should be avoided in .c files
#984: FILE: arch/x86/kernel/acpi/sleep.c:37:
+extern unsigned long FASTCALL(acpi_copy_wakeup_routine(unsigned long));

total: 2 errors, 13 warnings, 1615 lines checked

/home/lenb/Documents/wakeup.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/