linux-kernel - Re: [patch] move wakeup code to .c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2008 09:55:44 +0000
From:	Pavel Machek <pavel@....cz>
To:	Len Brown <lenb@...nel.org>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Linux-pm mailing list <linux-pm@...ts.osdl.org>,
	hpa@...or.com, rjw@...k.pl, sam@...nborg.org
Subject: Re: [patch] move wakeup code to .c

Hi!

> scripts/checkpatch.pl
> ERROR: do not initialise externals to 0 or NULL
> #113: FILE: arch/x86/boot/video-mode.c:29:
> +int do_restore = 0;    /* Screen contents changed during mode flip */

We were doing file move with minimal changes.

> ERROR: need a space before the open parenthesis '('
> #710: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:70:
> +               while(1);

Bogus warning.

I'll fix al but this one, but could we do it as a followup patch? I'm
currently at holidays, moving .S code into .c is rather
good/important, and it should get testing ASAP.
							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/