linux-kernel - Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080215191153.GA3667@uranus.ravnborg.org>
Date:	Fri, 15 Feb 2008 20:11:53 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, kkeil@...e.de,
	isdn4linux@...tserv.isdn4linux.de, Greg KH <greg@...ah.com>
Subject: Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion

> >
> >Just ran checkpatch for the fun of it:
> >total: 28 errors, 86 warnings, 4896 lines checked
> >Most looks easy to fix.
> 
> I'll take a look...  if its checkpatch stuff I caused, I'm happy to fix it.
> 
> But I'm trying to avoid cleanups for pre-existing conditions, i.e. 
> flagged by checkpatch only because I moved existing code to a new location.
> 
> Down that path lies madness and way too much work :)  I didn't sign on 
> to clean up ISDN :)
> 
> Anyway, thanks for the multiple comments, they will be taken into 
> account in the next update of these patches.

I was distracted when halfdone - but I assume that I would just
repeated myself for the rest of the drivers.

When you post an updated version I will try to take a little
bit deeper look. I did not get the full picture of the libification
you have made in hisax.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/