linux-kernel - Re: [PATCH 2/3] drivers/media/video/sn9c102/sn9c102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200802161909.44284.luca.risolia@studio.unibo.it>
Date:	Sat, 16 Feb 2008 19:09:44 +0100
From:	Luca Risolia <luca.risolia@...dio.unibo.it>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	linux-usb@...r.kernel.org, video4linux-list@...hat.com,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

It's okay, thanks.

Reviewed-by: Luca Risolia <luca.risolia@...dio.unibo.it>
---

On Saturday 16 February 2008 17:12:26 Roel Kluin wrote:
> The patch below was not yet tested. If it's incorrect, please comment.
> ---
> Fix Unlikely(x) == y
>
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
> b/drivers/media/video/sn9c102/sn9c102_core.c index c40ba3a..66313b1 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam,
> void* mem, size_t len)
>
>  		/* Search for the SOF marker (fixed part) in the header */
>  		for (j = 0, b=cam->sof.bytesread; j+b < sizeof(marker); j++) {
> -			if (unlikely(i+j) == len)
> +			if (unlikely(i+j == len))
>  				return NULL;
>  			if (*(m+i+j) == marker[cam->sof.bytesread]) {
>  				cam->sof.header[cam->sof.bytesread] = *(m+i+j);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/