linux-kernel - Re: Geode GX/LX watchdog timer (RESEND)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080217145450.GB1403@cs181133002.pp.htv.fi>
Date:	Sun, 17 Feb 2008 16:54:50 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Arnd Hannemann <hannemann@...informatik.rwth-aachen.de>
Cc:	Iain Paton <ilp@...l.darkvoyage.org.uk>,
	Jordan Crouse <jordan.crouse@....com>,
	Andres Salomon <dilinger@...ued.net>, marc.jones@....com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	wim@...ana.be
Subject: Re: Geode GX/LX watchdog timer (RESEND)

On Sun, Feb 17, 2008 at 03:46:01PM +0100, Arnd Hannemann wrote:
> Hi,
> 
> Iain Paton wrote:
> > Arnd Hannemann wrote:
> > 
> >> I can confirm that it is still working fine :-)
> > 
> > Hi,
> > 
> > Has anyone managed to build this as a module against the full 2.6.24
> > release ?
> > 
> > I am seeing the following error:
> > 
> >   CC [M]  lib/zlib_inflate/infutil.o
> >   CC [M]  lib/zlib_inflate/inftrees.o
> >   CC [M]  lib/zlib_inflate/inflate_syms.o
> >   LD [M]  lib/zlib_inflate/zlib_inflate.o
> >   Building modules, stage 2.
> >   MODPOST 251 modules
> > ERROR: "geode_mfgpt_toggle_event" [drivers/watchdog/geodewdt.ko] undefined!
> > ERROR: "geode_mfgpt_alloc_timer" [drivers/watchdog/geodewdt.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> > 
> > 
> > arch/x86/kernel/mfgpt_32.c where these are defined seems to have been
> > built ok and they appear in System.map.
> > 
> > The only other thing I've done is to add "[PATCH] pata_cs5536 Fix
> > secondary port configuration" recently posted by Martin K. Petersen but
> > I don't believe that would cause this.
> > 
> > .config is available at http://pastebin.ca/907299
> 
> Never tried to built it as a module.
> Probably there are issues with that. If I remember correctly I saw a patch in 2.6.25-rc which
> mentioned that using mfgpt in modules won't work. Does this apply to 2.6.24 as well?

For using code from modules it must be explicitely EXPORT_SYMBOL{,GPL}'ed.

Adding
  EXPORT_SYMBOL_GPL(geode_mfgpt_toggle_event);
and
  EXPORT_SYMBOL_GPL(geode_mfgpt_alloc_timer);
below the respective functions in mfgpt_32.c should fix this issue.

> Best regards,
> Arnd Hannemann

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/