linux-kernel - Re: Geode GX/LX watchdog timer (RESEND)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B85C61.7060507@lkml.darkvoyage.org.uk>
Date:	Sun, 17 Feb 2008 16:10:09 +0000
From:	Iain Paton <ilp@...l.darkvoyage.org.uk>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Arnd Hannemann <hannemann@...informatik.rwth-aachen.de>,
	Jordan Crouse <jordan.crouse@....com>,
	Andres Salomon <dilinger@...ued.net>, marc.jones@....com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	wim@...ana.be
Subject: Re: Geode GX/LX watchdog timer (RESEND)

Adrian Bunk wrote:
> On Sun, Feb 17, 2008 at 03:46:01PM +0100, Arnd Hannemann wrote:
>> Never tried to built it as a module.
>> Probably there are issues with that. If I remember correctly I saw a patch in 2.6.25-rc which
>> mentioned that using mfgpt in modules won't work. Does this apply to 2.6.24 as well?
> 
> For using code from modules it must be explicitely EXPORT_SYMBOL{,GPL}'ed.
> 
> Adding
>   EXPORT_SYMBOL_GPL(geode_mfgpt_toggle_event);
> and
>   EXPORT_SYMBOL_GPL(geode_mfgpt_alloc_timer);
> below the respective functions in mfgpt_32.c should fix this issue.

I couldn't find the patch Arnd mentioned on lkml or in Linus git tree, 
but adding the lines suggested by Adrian gets me a working module.

Hopefully the patch will arrive in the mainline tree at some point.

Thanks to both of you for the help!

Iain


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/