linux-kernel - Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080218031202.GD30201@elte.hu>
Date:	Mon, 18 Feb 2008 04:12:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	"David P. Reed" <dpreed@...d.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls.


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> On Sun, 17 Feb 2008 16:56:42 -0500 (EST)
> "David P. Reed" <dpreed@...d.com> wrote:
> 
> > Fix pcspkr driver to use explicit timing delay for access to PIT,
> > rather than inb_p/outb_p calls, which use insufficiently explicit
> 
> NAK.
> 
> We now have inb_pit and outb_pit to make the transition easier - can 
> you switch to those instead of coding internal knowledge outside of 
> the kernel methods.

please also Cc: Dmitry Torokhov <dtor_core@...ritech.net> to 
drivers/input/ patches. Once inb_pit/outb_pit is used, as suggested by 
Alan, i ack the patch from the arch/x86 perspective.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/