linux-kernel - Re: [PATCH] x86: Coding style fixes for arch/x86/kernel/cpu/centaur.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1203304344.7181.45.camel@localhost>
Date:	Sun, 17 Feb 2008 19:12:24 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: Coding style fixes for
	arch/x86/kernel/cpu/centaur.c

On Mon, 2008-02-18 at 03:56 +0100, Ingo Molnar wrote:
>  arch/x86/kernel/cpu/centaur.c |  394 +++++++++++++++++++++---------------------
>  1 file changed, 199 insertions(+), 195 deletions(-)
> 
> Index: linux-x86.q/arch/x86/kernel/cpu/centaur.c
> ===================================================================
> --- linux-x86.q.orig/arch/x86/kernel/cpu/centaur.c
> +++ linux-x86.q/arch/x86/kernel/cpu/centaur.c
> @@ -52,13 +54,12 @@ static u32 __cpuinit ramtop(void)		/* 16
>  		if (e820.map[i].addr > 0xFFFFFFFFUL)
>  			continue;
>  		/*
> -		 *	Don't MCR over reserved space. Ignore the ISA hole
> -		 *	we frob around that catastrophe already
> +		 * Don't MCR over reserved space. Ignore the ISA hole
> +		 * we frob around that catastrophe already
>  		 */
> -
> -		if (e820.map[i].type == E820_RESERVED)
> -		{
> -			if (e820.map[i].addr >= 0x100000UL && e820.map[i].addr < clip)
> +		if (e820.map[i].type == E820_RESERVED) {
> +			if (e820.map[i].addr >= 0x100000UL &&
> +						e820.map[i].addr < clip)
>  				clip = e820.map[i].addr;

Doesn't this look better as:

+			if (e820.map[i].addr >= 0x100000UL &&
+			    e820.map[i].addr < clip)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/