[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080218193030.GX22671@ca-server1.us.oracle.com>
Date: Mon, 18 Feb 2008 11:30:30 -0800
From: Mark Fasheh <mark.fasheh@...cle.com>
To: Joonwoo Park <joonwpark81@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
kurt.hackel@...cle.com
Subject: Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary
initialization
On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
> default_groups was allocated with kcalloc, so initialize to NULL
> is unnecessary.
NACK - this isn't a performance critical section of code and that line makes
the array termination obvious, so I'm inclined to leave it as is.
Thanks,
--Mark
--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@...cle.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists