linux-kernel - Re: [PATCH] linux/hdsmart.h: fix goofups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30744.1203311197@turing-police.cc.vt.edu>
Date:	Mon, 18 Feb 2008 00:06:37 -0500
From:	Valdis.Kletnieks@...edu
To:	"Robert P. J. Day" <rpjday@...shcourse.ca>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/hdsmart.h: fix goofups

On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said:

> if that header file isn't used by any kernel code, why bother having a
> check for __KERNEL__ in the first place?  it's being exported to
> userspace unchecked:
> 
>   include/linux/Kbuild:header-y += hdsmart.h
> 
> so why not just toss that check entirely?  otherwise, you're going to
> get a header file exported to userspace that has a superfluous
> __KERNEL__ test in it.

Umm... if the kernel isn't using it, why are we bothering to export it to
userspace at all?  Or is the kernel using something *else* that should be going
to userspace instead?

Content of type "application/pgp-signature" skipped