linux-kernel - Re: [PATCH 4/5] ide-generic: use ide_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47BACC7C.6030305@ru.mvista.com>
Date:	Tue, 19 Feb 2008 15:33:00 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] ide-generic: use ide_find_port()

Bartlomiej Zolnierkiewicz wrote:

> There should be no functional changes caused by this patch.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

> Index: b/drivers/ide/ide-generic.c
> ===================================================================
> --- a/drivers/ide/ide-generic.c
> +++ b/drivers/ide/ide-generic.c
> @@ -90,18 +90,27 @@ static int __init ide_generic_init(void)
>  	int i;
>  
>  	for (i = 0; i < MAX_HWIFS; i++) {
> -		ide_hwif_t *hwif = &ide_hwifs[i];
> +		ide_hwif_t *hwif;
>  		unsigned long io_addr = ide_default_io_base(i);
>  		hw_regs_t hw;
>  
> -		if (hwif->chipset == ide_unknown && io_addr) {
> -			u8 oldnoprobe = hwif->noprobe;
> +		if (io_addr) {
> +			u8 oldnoprobe;
> +
> +			/*
> +			 * Skip probing if the corresponding
> +			 * slot entry is already occupied.

    IMHO, it's either "slot" or "entry", else it sounds superfluous. :-)

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/