linux-kernel - Re: USB HID: Missing keys on Gyration Media Center Universal Remote Control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2008 13:43:11 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	"Adolfo R. Brandes" <arbrandes@...il.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: USB HID: Missing keys on Gyration Media Center Universal Remote
 Control

On Tue, 12 Feb 2008, Adolfo R. Brandes wrote:

> However, the TV key is still not seen by the X server (tested using
> xev and evrouter).  I'm attaching 3 files:
> * hid-input.c.patch: your patch with compilation warnings and errors
> fixed, against 2.6.24-rc6.
> * kern0.log: hid-debug and evbug output for these events: Connect, 0
> Key, Sleep Key, 0 Key, TV Key, Disconnect.
> * usbmon0.log: usbmon output for the same sequence of events (but at a
> different point in time).

Thanks for the data. The "TV" key is indeed very strange, as there seems 
to be report received, corresponding usbmon log:

de8ec680 1405369735 C Ii:2:014:2 0:8 3 = 064600
de8ec680 1405369751 S Ii:2:014:2 -115:8 5 <

but only the "release" report, that is sent just afterwards, seems to have 
reached HID layer, I don't know why. Could you please test the patch 
below, and send me the output?

diff --git a/drivers/hid/hid-input-quirks.c b/drivers/hid/hid-input-quirks.c
index a870ba5..99f05ce 100644
--- a/drivers/hid/hid-input-quirks.c
+++ b/drivers/hid/hid-input-quirks.c
@@ -418,6 +418,27 @@ void hidinput_event_quirks(struct hid_device *hid, struct hid_field *field, stru
 		input_event(input, usage->type, REL_WHEEL, -value);
 		return;
 	}
+	/* "Sleep" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			(usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK &&
+			(usage->hid & 0xf0) == 0x80 &&
+			(usage->hid & 0xf) == 0x2) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+	/* "TV" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			(usage->hid & HID_USAGE_PAGE) == HID_UP_LOGIVENDOR &&
+			(usage->hid & HID_USAGE) == 0x0000) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
 }
 
 
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 5325d98..45b8059 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -721,8 +721,13 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 		case HID_UP_LOGIVENDOR:
 
-			goto ignore;
-		
+			set_bit(EV_REP, input->evbit);
+			switch(usage->hid & HID_USAGE) {
+				case 0x027: map_key_clear(KEY_TV);	break;
+				default: goto ignore;
+			};
+			break;
+
 		case HID_UP_PID:
 
 			switch(usage->hid & HID_USAGE) {
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index d95979f..650322b 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -195,6 +195,8 @@ static void hid_irq_in(struct urb *urb)
 	struct usbhid_device 	*usbhid = hid->driver_data;
 	int			status;
 
+	printk(KERN_DEBUG "input irq status %d received. len == %x\n",
+			urb->status, urb->actual_length);
 	switch (urb->status) {
 		case 0:			/* success */
 			usbhid->retry_delay = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/