linux-kernel - tee(2) and SPLICE_F_NONBLOCK and can't find eof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1203435692.5949.84.camel@tng>
Date:	Tue, 19 Feb 2008 10:41:32 -0500
From:	Patrick McManus <mcmanus@...ksong.com>
To:	linux kernel ml <linux-kernel@...r.kernel.org>
Subject: tee(2) and SPLICE_F_NONBLOCK and can't find eof

[I initially sent this query inappropriately to an individual instead of
the list. My apologies.]

re: tee().. I was just playing around with the simple sample on the
manpage (included below) - it uses SPLICE_F_NONBLOCK as a flag. 

on 2.6.22 X86_64 (ubuntu 7.10) when I run the sample. the tee() system
call returns the right number of bytes from the input - sometimes as the
sum of multiple calls. When the input is exhauted tee() starts returning
(-1,EAGAIN) forever.. it never returns 0 and the program never
completes.

without a 0, how is EOF indicated?

do_tee() contains:
       if (!ret && (flags & SPLICE_F_NONBLOCK))
               ret = -EAGAIN;

so it's pretty clear where it comes from.. but finding EOF eludes me ;)
remove the NONBLOCK flag and 0 happens just fine.

NONBLOCK seems gratuitous in the sample, but it would make sense in some
code I am contemplating.. 

Any suggestions?

-Patrick

(This is the sample from the manpage which never completes.. I invoke it
as "cat txt | ./teesample out1 | wc ")

int
main(int argc, char *argv[])
{
    int fd;
    int len, slen;

    assert(argc == 2);

    fd = open(argv[1], O_WRONLY | O_CREAT | O_TRUNC, 0644);
    if (fd == -1) {
        perror("open");
        exit(EXIT_FAILURE);
    }

    do {
        /*
         * tee stdin to stdout.
         */
        len = tee(STDIN_FILENO, STDOUT_FILENO,
                  INT_MAX, SPLICE_F_NONBLOCK);

        if (len < 0) {
            if (errno == EAGAIN)
                continue;
            perror("tee");
            exit(EXIT_FAILURE);
        } else
            if (len == 0)
                break;

        /*
         * Consume stdin by splicing it to a file.
         */
        while (len > 0) {
            slen = splice(STDIN_FILENO, NULL, fd, NULL,
                          len, SPLICE_F_MOVE);
            if (slen < 0) {
                perror("splice");
                break;
            }
            len -= slen;
        }
    } while (1);

    close(fd);
    exit(EXIT_SUCCESS);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/