[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080220132100.c168fc20.randy.dunlap@oracle.com>
Date: Wed, 20 Feb 2008 13:21:00 -0800
From: Randy Dunlap <randy.dunlap@...cle.com>
To: lkml <linux-kernel@...r.kernel.org>
Cc: gregkh <greg@...ah.com>, akpm <akpm@...ux-foundation.org>
Subject: [PATCH 2/2] firmware: fix a few build errors
From: Randy Dunlap <randy.dunlap@...cle.com>
Fix one typo (comma to semi-colon).
Fix sysfs externs (just use sysfs.h for prototypes).
Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file'
include/linux/sysfs.h:100: error: previous declaration of 'sysfs_remove_bin_file' was here
Still has a build error:
ERROR: "firmware_class" [samples/firmware_class/firmware_sample_firmware_class.ko]
undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
samples/firmware_class/firmware_sample_firmware_class.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- linux-2625-rc2-docsrc.orig/samples/firmware_class/firmware_sample_firmware_class.c
+++ linux-2625-rc2-docsrc/samples/firmware_class/firmware_sample_firmware_class.c
@@ -33,9 +33,6 @@ struct class_device_attribute *to_class_
return container_of(_attr,struct class_device_attribute,attr);
}
-int sysfs_create_bin_file(struct kobject * kobj, struct bin_attribute * attr);
-int sysfs_remove_bin_file(struct kobject * kobj, struct bin_attribute * attr);
-
struct firmware_priv {
char fw_id[FIRMWARE_NAME_MAX];
s32 loading:2;
@@ -127,7 +124,7 @@ static int fw_setup_class_device(struct
class_dev->class_id[BUS_ID_SIZE-1] = '\0';
class_dev->dev = device;
- class_dev->class = &firmware_class,
+ class_dev->class = &firmware_class;
class_set_devdata(class_dev, fw_priv);
retval = class_device_register(class_dev);
if (retval){
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists