linux-kernel - Re: [PATCH] viocons: BKL locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080221221035.3e6e263a.sfr@canb.auug.org.au>
Date:	Thu, 21 Feb 2008 22:10:35 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Paul Mackerras <paulus@...ba.org>, akpm@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] viocons: BKL locking

Hi Alan,

On Thu, 21 Feb 2008 10:50:56 +0000 Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
>
> On Thu, 21 Feb 2008 14:58:29 +1100
> Paul Mackerras <paulus@...ba.org> wrote:
> 
> > Alan Cox writes:
> > 
> > > For some weird reason I can't ascertain (translation "I think its
> > > broken") the viocons driver calls directly into the n_tty ldisc code even
> > > if another ldisc is in use. It'll probably break if you do that but I'm
> > > just fixing the locking and adding a comment that its horked.
> > 
> > Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead
> > of calling n_tty_ioctl -- do you agree?
> 
> I think that is probably what is intended. That would then bounce back
> throuh the tty layer to the right places.

The other thing to note is that viocons is deprecated (we wrote another
backend to hvc as an alternative console for legacy iSeries) and will
hopefully be removed sometime soon so don't spend any time on it.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped