linux-kernel - Re: [ofa-general] Re: Merging of completely unreviewed drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7vbq69pkqy.fsf@gitster.siamese.dyndns.org>
Date:	Thu, 21 Feb 2008 22:29:09 -0800
From:	Junio C Hamano <junio@...ox.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Al Viro <viro@...IV.linux.org.uk>, Adrian Bunk <bunk@...nel.org>,
	Greg Kroah-Hartman <greg@...ah.com>,
	David Newall <davidn@...idnewall.com>,
	Krzysztof Halasa <khc@...waw.pl>, linux-kernel@...r.kernel.org,
	general@...ts.openfabrics.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Glenn Streiff <gstreiff@...Effect.com>,
	Roland Dreier <rdreier@...co.com>,
	Faisal Latif <flatif@...Effect.com>
Subject: Re: [ofa-general] Re: Merging of completely unreviewed drivers

Linus Torvalds <torvalds@...ux-foundation.org> writes:

> So I'd be happier with warnings about deep indentation (but how do you 
> count it? Will people then try to fake things out by using 4-space indents 
> and then "deep" indentations will look like just a couple of tabs?) and 
> against complex expressions (ie "if ((a = xyz()) == NULL) .." should just 
> be split up into "a = xyz(); if (!a) ..", but there are sometimes reasons 
> for those things too!

Deep indentation should be fairly easy, given that you
already have rules in place that says "Tabs are 8 characters".
So if you find a line that begins with more than say 4 SP, you
can flag that as already bogus (i.e. "does not indent with HT"),
more than 8 SP definitely so.

I'll leave harder "complex expressions" to sparse experts ;-),

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/