linux-kernel - Re: Merging of completely unreviewed drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c0942db0802212237t41da54b4h2aa2b052b7633f53@mail.gmail.com>
Date:	Thu, 21 Feb 2008 22:37:00 -0800
From:	"Ray Lee" <ray-lk@...rabbit.org>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Al Viro" <viro@...iv.linux.org.uk>,
	"David Newall" <davidn@...idnewall.com>,
	"Krzysztof Halasa" <khc@...waw.pl>,
	"Adrian Bunk" <bunk@...nel.org>,
	"Roland Dreier" <rdreier@...co.com>,
	"Glenn Streiff" <gstreiff@...effect.com>,
	"Faisal Latif" <flatif@...effect.com>,
	linux-kernel@...r.kernel.org, general@...ts.openfabrics.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Greg Kroah-Hartman" <greg@...ah.com>
Subject: Re: Merging of completely unreviewed drivers

On Thu, Feb 21, 2008 at 7:13 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>  So I'd be happier with warnings about deep indentation (but how do you
>  count it? Will people then try to fake things out by using 4-space indents
>  and then "deep" indentations will look like just a couple of tabs?)

I suspect that 90% of the cases that people really care about would
get caught successfully just by counting brace depth.

ie, by looking at { { {} {} {{{}{}}} } } I bet you can tell me which
section should have been pulled out into a separate routine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/