linux-kernel - Re: usb/serial/io_ti.c: inconsequent NULL checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080222101016.37128803@core>
Date:	Fri, 22 Feb 2008 10:10:16 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Ray Lee" <ray-lk@...rabbit.org>
Cc:	"Greg KH" <gregkh@...e.de>, "Adrian Bunk" <bunk@...nel.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: usb/serial/io_ti.c: inconsequent NULL checking

> Either the test of port->tty here is unneeded:
> 
>  if (port->tty)
>                port->tty->low_latency = low_latency;
> 
> ...or the lack of test of port->tty here is a mistake:
> 
> 	 edge_set_termios (port, port->tty->termios);

Interesting - so coverity doesn't understand the BKL. It's producing the
right answer, for the right reason but the assumption it makes isn't 100%
safe.

The check can go.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/