linux-kernel - Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47BEA53B.6090903@gmail.com>
Date:	Fri, 22 Feb 2008 11:34:35 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	torvalds@...l.org, jeff@...zik.org
Subject: Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

On 02/22/2008 11:02 AM, Alan Cox wrote:
> On Fri, 22 Feb 2008 09:48:28 +0000
> Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
>>>     Signed-off-by: Crane Cai <crane.cai@....com>
>>>     Acked-by: Jeff Garzik <jeff@...zik.org>
>>>     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
>> Vomitted-upon-by: Alan Cox <alan@...hat.com>
>>
>>> -	if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
>>> -		u8 tmp;
>>> +	/* set sb600/sb700/sb800 sata to ahci mode */
>>> +	u8 tmp;
>>>  
>>> +	pci_read_config_byte(pdev, PCI_CLASS_DEVICE, &tmp);
>>> +	if (tmp == 0x01) {
>> CLASS_DEVICE is cached in pdev->class so why not simply do:
>>
>> 	if (pdev->class & (1 << 8))
> 
> or better yet
> 
> 	((pdev->class & 0xFF00) == 0x0100)

Isn't it what was there before the change:
 >>> -	if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
 >>> -		u8 tmp;
and there was some reason to change it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/