linux-kernel - Re: [ofa-general] Re: Merging of completely unreviewed drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2e108260802221111x25c7b762i2326058fc49d6338@mail.gmail.com>
Date:	Fri, 22 Feb 2008 20:11:09 +0100
From:	"Bart Van Assche" <bart.vanassche@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Adrian Bunk" <bunk@...nel.org>,
	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	"Greg Kroah-Hartman" <greg@...ah.com>,
	"Roland Dreier" <rdreier@...co.com>, linux-kernel@...r.kernel.org,
	general@...ts.openfabrics.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Glenn Streiff" <gstreiff@...effect.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Faisal Latif" <flatif@...effect.com>
Subject: Re: [ofa-general] Re: Merging of completely unreviewed drivers

On Fri, Feb 22, 2008 at 7:54 PM, Ingo Molnar <mingo@...e.hu> wrote:
>     If a patch or if a file has a clean _style_, bugs and deeper
>     structural problems often stand out like a sore thumb. But if the
>     code is peppered with random style noise, it's a lot harder (for me
>     at least) to notice real bugs. I can notice bugs in a squeeky clean
>     code base about 5 times easier than in a noisy codebase. This effect
>     alone makes checkpatch indispensible for the scheduler and for
>     arch/x86.

I also appreciate style uniformity in kernel code. My (limited)
experience with checkpatch is that most checkpatch complaints are easy
to resolve.

Bart Van Assche.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/