| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Feb 2008 03:23:45 +0100 From: Krzysztof Halasa <khc@...waw.pl> To: Al Viro <viro@...IV.linux.org.uk> Cc: David Newall <davidn@...idnewall.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Adrian Bunk <bunk@...nel.org>, Roland Dreier <rdreier@...co.com>, Glenn Streiff <gstreiff@...Effect.com>, Faisal Latif <flatif@...Effect.com>, linux-kernel@...r.kernel.org, general@...ts.openfabrics.org, Andrew Morton <akpm@...ux-foundation.org>, Greg Kroah-Hartman <greg@...ah.com> Subject: Re: Merging of completely unreviewed drivers Al Viro <viro@...IV.linux.org.uk> writes: > ... if your style is lousy. I agree that situation with printks is > not normal in that respect and I certainly have no love for the > checkpatch nonsense, but pressure to keep the fucking nesting depth > low is a Good Thing(tm). Indeed. Unfortunately it is orthogonal to the line length limit. We should limit the nesting level, though I think there is no universally good value. What is good for one case (a function with a short multi-level if/for/etc) is bad for another (a long switch() where any added complexity makes it unparseable). So I think it just have to meet the author's and reviewers' taste. We already depend on this. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists