[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080223000426.adf5c75a.akpm@linux-foundation.org>
Date: Sat, 23 Feb 2008 00:04:26 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: balbir@...ux.vnet.ibm.com
Cc: menage@...gle.com, xemul@...nvz.org, balbir@...ibm.com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller
On Fri, 22 Feb 2008 09:59:41 +0530 Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> menage@...gle.com wrote:
> > Update the memory controller to use read_uint for its
> > limit/usage/failcnt control files, calling the new
> > res_counter_read_uint() function.
> >
> > Signed-off-by: Paul Menage <menage@...gle.com>
> >
>
> Hi, Paul,
>
> Looks good, except for the name uint(), can we make it u64(). Integers are 32
> bit on both ILP32 and LP64, but we really read/write 64 bit values.
>
yup, I agree. Even though I don't know what ILP32 and LP64 are ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists