linux-kernel - Re: x86: geode: MSR cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080225155255.GE13031@cosmic.amd.com>
Date:	Mon, 25 Feb 2008 08:52:55 -0700
From:	"Jordan Crouse" <jordan.crouse@....com>
To:	"Andres Salomon" <dilinger@...ued.net>
cc:	"Thomas Gleixner" <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, info-linux@...de.amd.com,
	mingo@...hat.com, hpa@...or.com, akpm@...ux-foundation.org
Subject: Re: x86: geode: MSR cleanup

On 24/02/08 18:33 -0500, Andres Salomon wrote:
> Note that I didn't bother cleaning up the gxfb and lxfb headers wrt MSRs;
> that's coming in another patch (which is still in progress).
> 
> 
> From 22b8ddf47f77f01a59afb937779f4c83e9862f9e Mon Sep 17 00:00:00 2001
> From: Andres Salomon <dilinger@...ian.org>
> Date: Sun, 24 Feb 2008 13:14:57 -0500
> Subject: [PATCH] x86: geode: MSR cleanup
> 
> This cleans up a few MSR-using drivers in the following manner:
>   - Ensures MSRs are all defined in asm/geode.h, rather than in misc
>     places
>   - Makes the naming consistent; cs553[56] ones begin with MSR_,
>     GX-specific ones start with MSR_GX_, and LX-specific ones start
>     with MSR_LX_.  Also, make the names match the data sheet.
>   - Use MSR names rather than numbers in source code
>   - Document the fact that the LX's MSR_PADSEL has the wrong value
>     in the data sheet.  That's, uh, good to note.
> 
> Signed-off-by: Andres Salomon <dilinger@...ian.org>

Acked-by: Jordan Crouse <jordan.crouse@....com>

Thanks for doing this - I'm always happy when stuff gets scratched off my
TODO list automatically.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/