linux-kernel - Re: latest commit on thinkpad_acpi.c 6c231bd5eb07 shows warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080225190149.GD16513@khazad-dum.debian.net>
Date:	Mon, 25 Feb 2008 16:01:49 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Zdenek Kabelac <zdenek.kabelac@...il.com>
Cc:	linux-kernel@...r.kernel.org, len.brown@...el.com
Subject: Re: latest commit on thinkpad_acpi.c 6c231bd5eb07 shows warning

On Sun, 24 Feb 2008, Zdenek Kabelac wrote:
> Commit 6c231bd5eb07ce546517019f334652b9ecfc329a
> generate this warning:
> 
> drivers/misc/thinkpad_acpi.c: In function 'tpacpi_input_send_tabletsw':
> include/linux/input.h:1290: warning: 'state' is used uninitialized in
> this function
> drivers/misc/thinkpad_acpi.c:1191: note: 'state' was declared here
> drivers/misc/thinkpad_acpi.c: In function 'hotkey_tablet_mode_show':
> drivers/misc/thinkpad_acpi.c:1723: warning: 's' is used uninitialized
> in this function

I can't seem to get these warnings in Debian gcc 4.2.3-1.  But the code is
broken alright.  I will send in a fix in a short while, as it will take a
small while to make sure there is nothing else wrong before I send in the
fix.   I have to figure out how the heck that got past the testing in the
first place, as well...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/