| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c4e36d110802251111m45a14375jf620b51229479c9b@mail.gmail.com> Date: Mon, 25 Feb 2008 20:11:55 +0100 From: "Zdenek Kabelac" <zdenek.kabelac@...il.com> To: "Henrique de Moraes Holschuh" <hmh@....eng.br> Cc: linux-kernel@...r.kernel.org, len.brown@...el.com Subject: Re: latest commit on thinkpad_acpi.c 6c231bd5eb07 shows warning 2008/2/25, Henrique de Moraes Holschuh <hmh@....eng.br>: > On Sun, 24 Feb 2008, Zdenek Kabelac wrote: > > > Commit 6c231bd5eb07ce546517019f334652b9ecfc329a > > generate this warning: > > > > drivers/misc/thinkpad_acpi.c: In function 'tpacpi_input_send_tabletsw': > > include/linux/input.h:1290: warning: 'state' is used uninitialized in > > this function > > drivers/misc/thinkpad_acpi.c:1191: note: 'state' was declared here > > drivers/misc/thinkpad_acpi.c: In function 'hotkey_tablet_mode_show': > > drivers/misc/thinkpad_acpi.c:1723: warning: 's' is used uninitialized > > in this function > > > I can't seem to get these warnings in Debian gcc 4.2.3-1. But the code is > broken alright. I will send in a fix in a short while, as it will take a > small while to make sure there is nothing else wrong before I send in the > fix. I have to figure out how the heck that got past the testing in the > first place, as well... Try gcc-4.3 (or gcc-snapshot) - makes much better/deeper code analysis. Zdenek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists