linux-kernel - Re: [PATCH] Change a WARN message in checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Feb 2008 03:29:44 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
Cc:	Benny Halevy <bhalevy@...asas.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Change a WARN message in checkpatch

On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@...asas.com> wrote:
> [...]
> >  How about:
> >  -                               WARN("no space between function name and open parenthesis '('\n" . $herecurr);
> >  +                               WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
> 
> I originally suggested:
> +                               WARN("don't put a space between
> function name and open parenthesis '('\n" . $herecurr);
> but I really prefer your version.
> 
> >  The original phrasing can be interpreted like "there is no space between ..." and the correct
> >  interpretation should be "there should be no space between ..."
> 
> Indeed.

As we want the messages to be as short as possible, I am leaning towards
standardising on:

	spaces prohibited <where>
	spaces required <where>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/