[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0802261230510.30955@jikos.suse.cz>
Date: Tue, 26 Feb 2008 12:37:17 +0100 (CET)
From: Jiri Kosina <jkosina@...e.cz>
To: Ingo Molnar <mingo@...e.hu>
cc: Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
Nix <nix@...eri.org.uk>, Peter Osterlund <petero2@...ia.com>,
linux-kernel@...r.kernel.org, dm-devel@...hat.com,
Jan Kara <jack@....cz>
Subject: Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd
related? dm-related?
On Tue, 26 Feb 2008, Ingo Molnar wrote:
> > + name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > + fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > +
> > + if (!name || !fname) {
> > + *err = -ENOMEM;
> > + return NULL;
> > + }
> > +
> > if (dentry) {
> > if (!dentry->d_name.len) {
> > *err = -EINVAL;
> this bit is missing i think:
> if (name)
> kfree(name);
> if (fname)
> kfree(fname);
Ergh, of course, stupid me, sorry, it should be freed on all exit paths. I
am not sending updated patch, as Jan is probably working on complete
removal of one of those fields ... ?
Thanks,
--
Jiri Kosina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists