linux-kernel - Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080226164123.GB28101@duck.suse.cz>
Date:	Tue, 26 Feb 2008 17:41:23 +0100
From:	Jan Kara <jack@...e.cz>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nix <nix@...eri.org.uk>, Peter Osterlund <petero2@...ia.com>,
	linux-kernel@...r.kernel.org, dm-devel@...hat.com,
	Jan Kara <jack@....cz>
Subject: Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow:
	ide-cd related? dm-related?

On Tue 26-02-08 12:37:17, Jiri Kosina wrote:
> On Tue, 26 Feb 2008, Ingo Molnar wrote:
> 
> > > +	name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > > +	fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > > +
> > > +	if (!name || !fname) {
> > > +		*err = -ENOMEM;
> > > +		return NULL;
> > > +	}
> > > +
> > >  	if (dentry) {
> > >  		if (!dentry->d_name.len) {
> > >  			*err = -EINVAL;
> > this bit is missing i think:
> > 	if (name)
> > 		kfree(name);
> > 	if (fname)
> > 		kfree(fname);
> 
> Ergh, of course, stupid me, sorry, it should be freed on all exit paths. I 
> am not sending updated patch, as Jan is probably working on complete 
> removal of one of those fields ... ?
  Yes, I'll convert one variable to kmalloc and the other one remove
completely. Stay tuned ;).

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/