linux-kernel - Re: 2.6.25-rc2-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080228191214.GA17872@elte.hu>
Date:	Thu, 28 Feb 2008 20:12:14 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Steven Rostedt <srostedt@...hat.com>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	linux-ia64 <linux-ia64@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>,
	Ingo Molnar <mingo@...hat.com>, Bob Picco <bob.picco@...com>,
	Eric Whitney <eric.whitney@...com>
Subject: Re: 2.6.25-rc2-mm1 - boot hangs on ia64


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Thu, 28 Feb 2008 12:50:41 +0100 Ingo Molnar <mingo@...e.hu> wrote:
> 
> > @@ -1000,7 +1001,7 @@ void release_console_sem(void)
> >  	 * If we try to wake up klogd while printing with the runqueue lock
> >  	 * held, this will deadlock.
> >  	 */
> > -	if (wake_klogd && !runqueue_is_locked())
> > +	if (wake_klogd)
> >  		wake_up_klogd();
> >  }
> 
> I don't think we shoudl have added that hack in the first place.  It 
> solves a problem which about three developers hit four times in five 
> years but it has made kernel logging less reliable for everyone.

well, the problem was ia64, not a problem on x86 or other platforms. The 
problem here is ia64 not setting up percpu data structures soon enough. 
It has blown up in the past in other areas, and it will likely blow up 
in the future in other areas as well. It's just not robust to have init 
dependencies on such basic data structures like percpu areas like that.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/