[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080228112423.fed6add2.akpm@linux-foundation.org>
Date: Thu, 28 Feb 2008 11:24:23 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: kosaki.motohiro@...fujitsu.com, srostedt@...hat.com,
Lee.Schermerhorn@...com, linux-ia64@...r.kernel.org,
linux-kernel@...r.kernel.org, tony.luck@...el.com,
mingo@...hat.com, bob.picco@...com, eric.whitney@...com
Subject: Re: 2.6.25-rc2-mm1 - boot hangs on ia64
On Thu, 28 Feb 2008 20:12:14 +0100
Ingo Molnar <mingo@...e.hu> wrote:
>
> * Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> > On Thu, 28 Feb 2008 12:50:41 +0100 Ingo Molnar <mingo@...e.hu> wrote:
> >
> > > @@ -1000,7 +1001,7 @@ void release_console_sem(void)
> > > * If we try to wake up klogd while printing with the runqueue lock
> > > * held, this will deadlock.
> > > */
> > > - if (wake_klogd && !runqueue_is_locked())
> > > + if (wake_klogd)
> > > wake_up_klogd();
> > > }
> >
> > I don't think we shoudl have added that hack in the first place. It
> > solves a problem which about three developers hit four times in five
> > years but it has made kernel logging less reliable for everyone.
>
> well, the problem was ia64, not a problem on x86 or other platforms.
I am referring to the original change which made klogd wakeups unreliable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists