[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080228214141.296335a0@bree.surriel.com>
Date: Thu, 28 Feb 2008 21:41:41 -0500
From: Rik van Riel <riel@...hat.com>
To: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc: kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
Lee Schermerhorn <Lee.Schermerhorn@...com>, linux-mm@...ck.org,
Nick Piggin <npiggin@...e.de>
Subject: Re: [patch 01/21] move isolate_lru_page() to vmscan.c
On Fri, 29 Feb 2008 11:29:18 +0900
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
> We think this portion change to following code.
>
> ---------------------------------------------
> err = isolate_lru_page(page);
> if (!err)
> list_add_tail(&page->lru, &pagelist);
> put_and_set:
> put_page(page); /* drop follow_page() reference */
> ---------------------------------------------
If I understand you right, this is what the incremental patch looks like:
Index: linux-2.6.25-rc2-mm1/mm/migrate.c
===================================================================
--- linux-2.6.25-rc2-mm1.orig/mm/migrate.c 2008-02-28 21:32:20.000000000 -0500
+++ linux-2.6.25-rc2-mm1/mm/migrate.c 2008-02-28 21:32:14.000000000 -0500
@@ -841,16 +841,10 @@ static int do_move_pages(struct mm_struc
goto put_and_set;
err = isolate_lru_page(page);
- if (err) {
-put_and_set:
- /*
- * Either remove the duplicate refcount from
- * isolate_lru_page() or drop the page ref if it was
- * not isolated.
- */
- put_page(page);
- } else
+ if (!err)
list_add_tail(&page->lru, &pagelist);
+put_and_set:
+ put_page(page);
set_status:
pp->status = err;
}
Is this OK for me to commit to my tree?
(folding it into patch 01/21)
--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists